Review Request: Cue sheet not working for files in collection

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100301/#review735
-----------------------------------------------------------


This is clearly not the way to implement Cue support in SqlCollection.
The scanner needs to detect cue/mp3 pairs and the collection needs to create a track for each cue entry using timecode bounds.

But we already knew that, just haven't implemented it yet.

Anton: feel free to keep using your patch, but we probably will not merge it.

Bart

- Bart


On 2011-01-04 19:15:07, Anton Revunov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100301/
> -----------------------------------------------------------
> 
> (Updated 2011-01-04 19:15:07)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Cue sheet not working for files in collection
> 
> 
> This addresses bug 187587.
>     https://bugs.kde.org/show_bug.cgi?id=187587
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistController.h 421274d 
>   src/playlist/PlaylistController.cpp d38c9d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100301/diff
> 
> 
> Testing
> -------
> 
> I made a patch for Amarok 2.3.2 as a temporary solution. It works for me and my collection. Required to re-add tracks to the playlist. Does not work for drag-and-drop and maybe for something else.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110105/01cda523/attachment-0001.htm