Review Request: fix bug 266171. Add HTML <pre> tag in guitar tabs applet for tabs from ultimate-guitar.com

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100670/#review1466
-----------------------------------------------------------

Ship it!


Makes sense, yep. Can you push it yourself (to KDE git master), or should we do that?

- Mark


On Feb. 16, 2011, 8:19 p.m., Martin Kunkel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100670/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 8:19 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> TabsEngine displays the text from ultimate-guitar.com between the
> <pre>...</pre> tags in a browser. Thus, multiple spaces are reduced to one
> space which yields chords like
> 
> Bm F# 
> On a dark desert highway, cool wind in my hair 
> 
> (the F# chord should be over "cool")
> 
> Solution: the <pre> tag should be added.
> 
> 
> This addresses bug 266171.
>     https://bugs.kde.org/show_bug.cgi?id=266171
> 
> 
> Diffs
> -----
> 
>   src/context/engines/tabs/TabsEngine.cpp 7c893c6 
> 
> Diff: http://git.reviewboard.kde.org/r/100670/diff
> 
> 
> Testing
> -------
> 
> Tested with various songs from my library.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110216/29da0a20/attachment-0001.htm