Review Request: Add HTML <pre> tag in guitar tabs applet for tabs from ultimate-guitar.com

Martin Kunkel ich at martinkunkel.de
Wed Feb 16 21:18:42 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100670/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

TabsEngine displays the text from ultimate-guitar.com between the
<pre>...</pre> tags in a browser. Thus, multiple spaces are reduced to one
space which yields chords like

Bm F# 
On a dark desert highway, cool wind in my hair 

(the F# chord should be over "cool")

Solution: the <pre> tag should be added.


This addresses bug 266171.
    https://bugs.kde.org/show_bug.cgi?id=266171


Diffs
-----

  src/context/engines/tabs/TabsEngine.cpp 7c893c6 

Diff: http://git.reviewboard.kde.org/r/100670/diff


Testing
-------

Tested with various songs from my library.


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110216/224946d4/attachment.htm 


More information about the Amarok-devel mailing list