Review Request: New dynamic bias

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100630/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

This fix (actually not the attached patch but the dynamicplaylist branch) changes most of the dynamic playlist.

Main parts are the UI which was seen as confusing by many users and produced unexpected results.
The global bias is now a "part" bias which allows you to set a part of the collection matching a criteria.
The custom bias is now part of the bias system. I converted all existing custom biases to the new interface just to make sure that it's usable.
The fuzzy bias was completely removed. If someone really wants to have a bias which results in a normal distribution of one numeric value then please feel free to add it again. For now you can define this kind of bias by defining something like this "(rating > 1) AND (rating < 4)"

The branch needs to be merged back to mainline and might have conflicts.


This addresses bugs 175163, 175172, 177627, 188360, 188360, 228738, 230773, 232673, 233859, 260001, 260003, 265191, and, more, probably, and some.
    https://bugs.kde.org/show_bug.cgi?id=175163
    https://bugs.kde.org/show_bug.cgi?id=175172
    https://bugs.kde.org/show_bug.cgi?id=177627
    https://bugs.kde.org/show_bug.cgi?id=188360
    https://bugs.kde.org/show_bug.cgi?id=188360
    https://bugs.kde.org/show_bug.cgi?id=228738
    https://bugs.kde.org/show_bug.cgi?id=230773
    https://bugs.kde.org/show_bug.cgi?id=232673
    https://bugs.kde.org/show_bug.cgi?id=233859
    https://bugs.kde.org/show_bug.cgi?id=260001
    https://bugs.kde.org/show_bug.cgi?id=260003
    https://bugs.kde.org/show_bug.cgi?id=265191
    https://bugs.kde.org/show_bug.cgi?id=and
    https://bugs.kde.org/show_bug.cgi?id=more
    https://bugs.kde.org/show_bug.cgi?id=probably
    https://bugs.kde.org/show_bug.cgi?id=some


Diffs
-----

  ChangeLog 809d5e7 

Diff: http://git.reviewboard.kde.org/r/100630/diff


Testing
-------

Used it for a couple of times and wrote new auto tests.
Tested against bug reports.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110211/29f0c97c/attachment.htm