Review Request: Rely on the playbackStateChanged() signal to emit the StatusChange dbus signal

[Anthony Vital]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100602/
-----------------------------------------------------------

(Updated Feb. 8, 2011, 1:40 p.m.)


Review request for Amarok.


Changes
-------

Add bugs IDs that the fix would close.


Summary (updated)
-------

At the moment, the state returned by the StatusChange dbus signal is sometimes incorrect. For example, if one explicitly skip to the next song while playing, the status returned is 2 (i.e. 'Stopped'), instead of 0 ('Playing'). This occurs with the vlc phonon backend, using xine backend I had similar bugs.
Relying on the engineController's playbackStateChanged() signal instead of the ones used for now fixes these problems.
Fixes BUG#263917, and possibly BUG#256756 (the plasmoid part at least, I haven't been able to reproduce the tray icon bug anyway).


Diffs
-----

  src/dbus/mpris1/PlayerHandler.cpp c55ab7f 

Diff: http://git.reviewboard.kde.org/r/100602/diff


Testing
-------

Tested on debian with KDE 4.5 and archlinux with 4.6, both with Amarok 2.4.0.


Thanks,

Anthony

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110208/4409c4d5/attachment.htm