Review Request: Add an absolute date filter

[Daniel Faust]

> On Dec. 27, 2011, 8:51 a.m., Bart Cerneels wrote:
> > The code certainly looks good and it's a useful advanced feature. I have not tested it yet though.
> > How does it integrate with the query editor dialog?

What is the query editor dialog?

If you mean the EditFilterDialog, absolute dates are handled correctly and the handling of time differences has also been improved (unified across all components).


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103546/#review9291
-----------------------------------------------------------


On Dec. 26, 2011, 8:50 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103546/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2011, 8:50 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch adds a collection filter (including gui) to filter using an absolute date (e.g. 26.11.2011). It's an addition to the current time difference mode (e.g. 1 month ago).
> Currently filtering the collection by date is a bit confusing and even though there is a gui (in the EditFilterDialog) to select a certain date it gets instantly converted to a time difference. This patch make a clear difference between these two modes (absolute and relative time specification).
> 
> The date can be formatted in tree ways, default is the local short format (KLocale::ShortFormat) following regex are also possible:
> (\d{1,2})[-.](\d{1,2})
> (\d{1,2})[-.](\d{1,2})[-.](\d{4})
> 
> The way time differences are handled gets unified though that leads to some code duplication that should also be dealt with.
> A new filter condition 'NewerThan' (opposide of 'OlderThan') gets added.
> 
> I hope that I didn't forget anything important.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/TextualQueryFilter.h 31860a3 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 2374dbd 
>   src/dialogs/EditFilterDialog.cpp 58c2956 
>   src/widgets/MetaQueryWidget.h 3974fb7 
>   src/widgets/MetaQueryWidget.cpp 57b622f 
>   src/widgets/TokenPool.cpp 2889442 
> 
> Diff: http://git.reviewboard.kde.org/r/103546/diff/diff
> 
> 
> Testing
> -------
> 
> I tested filtering the collection and editing the filters with the EditFilterDialog.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111227/9f341357/attachment.html>