Request for review: my patch queue for 2.6

Matěj Laitl matej at laitl.cz
Sat Dec 24 14:40:02 UTC 2011


On 20. 12. 2011 Bart Cerneels wrote:
> Just make sure you squash the commits that belong together :)

Do you mean some specific commits? E.g. there are 3 UpdateCapability removal-
related commits, but each one stands on its own (with commit message 
describing the specific change) and everything is perfectly bisectable. (I must 
say I'm not a big fan of squashing related changes - I instead prefer the 
Linux-kernel way of thinking with git: make very granular commits so that it 
is `git bisect` who finds erroneous changes, not you)

> And don't forget to Changelog in the same commit!

I guess you're alluding to my past commits. I've improved, I swear! :)

So it seems nobody opposes merging the patch-set, so I'll do it once I find 
another bit of time in this holiday time..

		Matěj


More information about the Amarok-devel mailing list