Should we support building utilities without building player?

Bart Cerneels bart.cerneels at kde.org
Tue Dec 20 10:02:15 UTC 2011


On Mon, Dec 19, 2011 at 00:15, Matěj Laitl <matej at laitl.cz> wrote:
> Hi amarok-devel,
> while trying to solve Gentoo bug 390831 [1] I've found that it is currently
> (master branch) impossible to build Amarok utilities (amarokcollectionscanner
> and amarok_afttagger) without building the player itself. (Gentoo allows it
> among all other combinations)
>
> [1] https://bugs.gentoo.org/show_bug.cgi?id=390831
>
> The build failure in the bug report can be easily solved by moving
> configure_file(config-amarok.h.cmake ...) in CMakeLists around, but then a more
> serious one appears:
>
> shared/FileTypeResolver.cpp:57: undefined reference to `KMimeType::is(QString
> const&) const'
>
> The problem is that we don't require (and link to) kdelibs in utilities-only
> build. Because using mime type when identifying files is useful and I've found
> no Qt KMimeType alternative, I think we have 2 options:
>
> a) do not support building utilities without building player
> b) require kdelibs in utilities-only build
>
> I can do the b), but is there an actual use-case for building only utilities?
> Would linking to kdelibs hamper this use-case? (Paweł, Thomas?)
>
> Regards,
>                        Matěj Laitl

This probably broke when I move some classes between libraries. The
change was required for other commits, so can't be reverted, but it
should be fixed with an ifdef or something.
Having non-kdelibs linked collectionscanner is useful.

Bart


More information about the Amarok-devel mailing list