Where to place generic equalizer facilities.

Bart Cerneels bart.cerneels at kde.org
Mon Dec 5 07:44:37 UTC 2011


On Fri, Dec 2, 2011 at 23:53, Ryan McCoskrie <ryan.mccoskrie at gmail.com> wrote:
> I've been doing some on off work to make some standard functions for scripts
> and plugins to controll the equalizer through.
>
> So far I have been placing all of these in the EngineController class (and
> giving AmarokScriptEngine some wrap around functions) but the number of them
> is growing and I've started to wonder if I should make a new class to hold
> this behaviour?
>
> --

Yes. Because EngineController is already big enough as it is. I think
you should just make a script-controllable class that controls
EngineController. Look at Mpris2DBusHandler for inspiration.

Bart


More information about the Amarok-devel mailing list