Review Request: Enable find as you type support in the playlist

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102442/#review6023
-----------------------------------------------------------


Search-as-you-type is obviously preferred, but it needs to be implemented correctly. If there is any possibility of blocking the UI (even in extremely big playlists) it's a no go.

- Bart


On Aug. 26, 2011, 9:47 a.m., Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102442/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 9:47 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> If playlist has focus, typing characters switches focus to the search widget and the filter is applied.
> 
> The change is not very big, but do we want this capability?
> 
> 
> This addresses bug 192125.
>     https://bugs.kde.org/show_bug.cgi?id=192125
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistDock.h d8bbeed 
>   src/playlist/PlaylistDock.cpp 504f63c 
>   src/playlist/view/listview/PrettyListView.h f22a7c8 
>   src/playlist/view/listview/PrettyListView.cpp 9ce6573 
> 
> Diff: http://git.reviewboard.kde.org/r/102442/diff
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110826/fbc4f23c/attachment.html>