Review Request: Add new collection filter to find exact matches
Daniel Faust
hessijames at gmail.com
Mon Aug 8 14:38:13 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
Since I use labels quite intensive it sometimes comes handy to search for songs with an exact label, not just a label containing the string I'm searching for.
So I added a new filter type for this and used the '=' sign.
Searching for label=pop finds songs labeled with 'pop' but not with 'electro pop'.
While searching for label:pop finds songs labeled with 'pop' and 'electro pop'.
This is not integrated into the GUI like the EditFilterDialog since I wanted to hear your opinions first.
Diffs
-----
src/core-impl/collections/support/Expression.h 1e49f45
src/core-impl/collections/support/Expression.cpp 531850a
src/core-impl/collections/support/TextualQueryFilter.cpp 735772b
Diff: http://git.reviewboard.kde.org/r/102252/diff
Testing
-------
I'm using this patch for a few weeks now without any problems.
Screenshots
-----------
http://git.reviewboard.kde.org/r/102252/s/221/
Thanks,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110808/fce536ba/attachment.html>
More information about the Amarok-devel
mailing list