Review Request: Adds GPL notices to a couple of files.

Ralf Engels ralf-engels at gmx.de
Wed Aug 3 17:45:58 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102187/#review5361
-----------------------------------------------------------

Ship it!


I support patches that make the code better. Even if it's just comments and readability.

- Ralf


On Aug. 2, 2011, 5:47 p.m., Sandeep Raghuraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102187/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 5:47 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Added GPL notice to PodcastFilenameLayoutConfigDialog files. Also made minor changes so the code followed Amarok's coding style.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h 1a8480a 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp bc34202 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui d913882 
> 
> Diff: http://git.reviewboard.kde.org/r/102187/diff
> 
> 
> Testing
> -------
> 
> Compiles and runs. Only made minor changes, so no actual testing required.
> 
> 
> Thanks,
> 
> Sandeep
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110803/6b7b3128/attachment.html>


More information about the Amarok-devel mailing list