Review Request: Partial Rewrite of ID3v2TagHelper.cpp

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/#review5360
-----------------------------------------------------------


seems to be nicer to the eyes.

Do the unit test still run?

- Ralf


On July 22, 2011, 11:48 p.m., Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102055/
> -----------------------------------------------------------
> 
> (Updated July 22, 2011, 11:48 p.m.)
> 
> 
> Review request for Amarok and Ralf Engels.
> 
> 
> Summary
> -------
> 
> Rewrite if else else if Constructs to switch statements
> 
> Add common Frame Names to m_fieldMap
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/ID3v2TagHelper.cpp 27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 
>   shared/tag_helpers/TagHelper.h f8e7fd9fdad0ac3abd6efd34ad5e00c973233a6d 
>   shared/tag_helpers/TagHelper.cpp 96f763e0839b59194484c1aa94cd266d88ad5add 
> 
> Diff: http://git.reviewboard.kde.org/r/102055/diff
> 
> 
> Testing
> -------
> 
> compared output of collectionscanner before & after patch -> fixed some, but still some slight problems with TrackNo
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110803/a2ec3ef6/attachment.html>