Review Request: Fixing E-Mail RegExp in LikeBack Dialog

[Michael Düll]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101170/
-----------------------------------------------------------

(Updated April 21, 2011, 4:35 p.m.)


Review request for Amarok.


Changes
-------

I changed the RegExp to match (almost) all RFC-valid email addresses and built in a check for the users of exotic email addresses.


Summary
-------

This fixes the RegExp checking in the LikeBack system in amarok-git to support fully RFC conform local-parts of email addresses.

This is my first submitted patch. I hope I've done things right.


Diffs (updated)
-----

  src/likeback/LikeBackDialog.cpp b53dec5 

Diff: http://git.reviewboard.kde.org/r/101170/diff


Testing
-------

Tested with git version without a problem.


Thanks,

Michael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110421/68ce864e/attachment.htm