Review Request: Add autoscroll function to the lyrics applet.

[Jan Gerrit Marker]

> On April 21, 2011, 6:36 a.m., Bart Cerneels wrote:
> > Didn't test the patch but the concept and code look good.
> > 
> > How many tracks did you test this with? With all lyrics providers? Does the scroll line up with the actual song in all of the cases?

I think I tested about 20 songs from different artists (German, English). I installed a few providers after reading your comment and it was ok with them.
If there's a long intro sometimes one or two lines aren't shown anymore when they are sung but normally the song catches up with the text after one or two more lines.


- Jan Gerrit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101155/#review2786
-----------------------------------------------------------


On April 19, 2011, 5:07 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101155/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 5:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The text of the current song is automatically scrolled according to the position in the song. If the scrollbar is pressed and moved the autoscroll is disabled till the scollbar is released and it can be disabled/reactivated manually by clicking on an action. Whether autoscrolling is enabled or disabled is saved over Amarok restarts.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/lyrics/LyricsApplet.h 17c91bf 
>   src/context/applets/lyrics/LyricsApplet.cpp a9c6be3 
> 
> Diff: http://git.reviewboard.kde.org/r/101155/diff
> 
> 
> Testing
> -------
> 
> Tested and worked fine.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110421/9402daab/attachment-0001.htm