Review Request: Fix 266645: Update wikipedia applet when metadata in a stream changes.

[Elbin Pallimalil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100953/
-----------------------------------------------------------

(Updated April 3, 2011, 11:33 a.m.)


Review request for Amarok and Rick W. Chen.


Changes
-------

Removed irrelevant DEBUG_BLOCKs and left only the relevant ones. I don't have commit access so you have to help me out. Thanks in advance.


Summary
-------

WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to check if an update is required this member is queried to get the previous track's data. This of course would not work as this member always returns the current data when a stream is being played.

Can I replace this member with a struct to save Artist, Album and Track info? Bad idea?


This addresses bug 266645.
    https://bugs.kde.org/show_bug.cgi?id=266645


Diffs (updated)
-----

  src/context/engines/wikipedia/WikipediaEngine.cpp 1fe80ae 

Diff: http://git.reviewboard.kde.org/r/100953/diff


Testing
-------

Works with different streams. Tested by playing files as well.


Thanks,

Elbin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110403/6d71d597/attachment.htm