Review Request: Fix: Recently played tracks are not updated in currrent track applet.

[Rick W. Chen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/#review2332
-----------------------------------------------------------



src/context/widgets/RecentlyPlayedListWidget.cpp
<http://git.reviewboard.kde.org/r/101015/#comment2024>

    EngineController's trackChanged() signal is also sent when playback stops. Though at the moment RecentlyPlayedListWidget doesn't do anything with it (returns early since track pointer is 0). It's better to add the update there instead of adding another signal connection.


- Rick W.


On April 2, 2011, 10:45 p.m., Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101015/
> -----------------------------------------------------------
> 
> (Updated April 2, 2011, 10:45 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
> 
> It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.
> 
> 
> Diffs
> -----
> 
>   src/context/widgets/RecentlyPlayedListWidget.h b9b3d3b 
>   src/context/widgets/RecentlyPlayedListWidget.cpp 2959c1c 
> 
> Diff: http://git.reviewboard.kde.org/r/101015/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110403/c411fbf2/attachment.htm