Review Request: Bug 261062 - JJ: Mark episodes to keep

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100998/#review2300
-----------------------------------------------------------


Overall it looks very good, just worried about some possible regressions. Will try it myself.

On the UI front I wonder if we can figure out a way to display the keep state to the user using an icon emblem.


src/browsers/playlistbrowser/PodcastModel.cpp
<http://git.reviewboard.kde.org/r/100998/#comment1982>

    I would write something about not deleting downloaded files here. Translators are best kept over informed :)



src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
<http://git.reviewboard.kde.org/r/100998/#comment1985>

    I think this will reintroduce some bugs relating to podcast browser view updates. I explicitly tried to to avoid calling loadEpisodes()



src/core-impl/podcasts/sql/SqlPodcastProvider.cpp
<http://git.reviewboard.kde.org/r/100998/#comment1984>

    Does the behavior still make sense with this removed? Must have added it for a reason.


- Bart


On April 1, 2011, 2:59 p.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100998/
> -----------------------------------------------------------
> 
> (Updated April 1, 2011, 2:59 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked.
> These "kept" episodes are shown in the list regardless of the purgecount, even if they
> are not downloaded.
> 
> BUG Description:
> 
> Currently downloaded files are not kept when the episode is no longer shown in
> the Podcast section. This behavior can not be configured but is tied to the
> purge settings of each channel.
> 
> It's possible to add a "keep downloaded file" checkbox to episodes to prevent
> the deletion from happening. We should perhaps also show these "kept" episodes
> in the list regardless of the purgecount. So even if a channel has purgecount 5
> and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes.
> 
> Reproducible: Always
> 
> 
> This addresses bug 261062.
>     https://bugs.kde.org/show_bug.cgi?id=261062
> 
> 
> Diffs
> -----
> 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 2d3f1a5 
>   src/core/podcasts/PodcastMeta.h e11b2eb 
>   src/core/podcasts/PodcastMeta.cpp fb82fa8 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e 
>   src/browsers/playlistbrowser/PodcastModel.h ce1a86f 
>   src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 5bda713 
> 
> Diff: http://git.reviewboard.kde.org/r/100998/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110401/391e6490/attachment-0001.htm