Review Request: MusicBrainz and MusicDNS services support implementation

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100000/
-----------------------------------------------------------

(Updated 2010-09-30 21:56:36.292868)


Review request for amarok.


Changes
-------

Rebuild UI according to Thomas Pfeiffer comment.


Summary
-------

MusicBrainz and MusicDNS services support implementation.
There are three independent parts:
1. MusicBrainzFinder class - used to make requests to MusicBrainz server and process replies. All relies process in separate threads by MusicBrainzXmlParser class. For a search uses guessed from a file name track information.  No external dependences required.
2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, but i communicate with musicdns server and receives track's PUID as a reply. Replies ether process in separate threads by MusicDNSXmlParser class. Fingerprints generated by libofa (the only external dependence in entire patch). For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'm not sure is It a good choice, but amarok based on phonon media-engine, that uses xine. So we don't deed to pull any other dependences). Received PUIDs sends to MusicBrainzFinder class, for a search routine.
3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrackListModel) and display (MusicBrainzTagsModelDelegate) purposes.


Diffs (updated)
-----

  CMakeLists.txt 191b02e 
  cmake/modules/FindLibOFA.cmake PRE-CREATION 
  config-amarok.h.cmake 981b7b7 
  src/CMakeLists.txt ea5d155 
  src/dialogs/MusicBrainzTagger.h PRE-CREATION 
  src/dialogs/MusicBrainzTagger.cpp PRE-CREATION 
  src/dialogs/MusicBrainzTagger.ui PRE-CREATION 
  src/dialogs/TagDialog.h 50cd801 
  src/dialogs/TagDialog.cpp 68fc5e3 
  src/dialogs/TagDialogBase.ui 9974d0b 
  src/musicbrainz/MusicBrainzFinder.h PRE-CREATION 
  src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION 
  src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION 
  src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzTagsModelDelegate.h PRE-CREATION 
  src/musicbrainz/MusicBrainzTagsModelDelegate.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION 
  src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION 
  src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION 
  src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION 
  src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION 
  src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION 
  src/musicbrainz/MusicDNSFinder.h PRE-CREATION 
  src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION 
  src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION 
  src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100000/diff


Testing
-------


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100930/29ed7854/attachment.htm