Review Request: Use QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS for performance.

[Mark Kretschmann]

> On 2010-09-29 12:18:00, Rick W. Chen wrote:
> > src/browsers/playlistbrowser/DynamicModel.cpp, line 229
> > <http://git.reviewboard.kde.org/r/100008/diff/1/?file=464#file464line229>
> >
> >     i18n( "%1 (modified)", title )

fixed, thanks


> On 2010-09-29 12:18:00, Rick W. Chen wrote:
> > src/browsers/collectionbrowser/CollectionWidget.cpp, lines 176-178
> > <http://git.reviewboard.kde.org/r/100008/diff/1/?file=463#file463line176>
> >
> >     The "added" i18n string is taken from CollectionTreeItemModelBase::addFilters(). They need to be the same so that the filtering will work. So it might break if the translation uses different "added" for the two places.
> >     
> >     Similarly, the 'd', 'w', 'm' etc. are also hardcoded in CollectionTreeItemModelBase::semanticDateTimeParser(). So the same thing applies here.
> >     
> >     Ideally we should make all of them translatable with context while ensuring they are consistent.

Could you please elaborate? What concrete solution do you suggest, in code?


> On 2010-09-29 12:18:00, Rick W. Chen wrote:
> > src/core-impl/collections/daap/DaapCollection.cpp, line 267
> > <http://git.reviewboard.kde.org/r/100008/diff/1/?file=468#file468line267>
> >
> >     Single quote for a single char?

Fixed, thanks.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100008/#review38
-----------------------------------------------------------


On 2010-09-29 09:36:12, Mark Kretschmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100008/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 09:36:12)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
>     Use QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS for performance.
>     
>     See http://doc.trolltech.com/4.6/qstring.html#more-efficient-string-construction.
>     
>     I had to clean up lots of incorrect string concatenations. Please check for
>     correctness.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt abdcee8 
>   src/aboutdialog/OcsPersonItem.cpp 6685aa1 
>   src/browsers/collectionbrowser/CollectionWidget.cpp 196837c 
>   src/browsers/playlistbrowser/DynamicModel.cpp af7742d 
>   src/context/applets/similarartists/SimilarArtistsApplet.cpp e1e5d59 
>   src/context/applets/upcomingevents/UpcomingEventsApplet.cpp 7233785 
>   src/core-impl/collections/audiocd/AudioCdCollection.cpp a10976b 
>   src/core-impl/collections/daap/DaapCollection.cpp 06e97b2 
>   src/core-impl/collections/sqlcollection/SqlCollectionLocation.cpp e9411e6 
>   src/core-impl/collections/sqlcollection/mysqlecollection/MySqlEmbeddedStorage.cpp b3b40bc 
>   src/core/support/Debug.h 62766c4 
>   src/dynamic/Bias.cpp dec2db2 
>   src/dynamic/BiasSolver.cpp 0be91da 
>   src/dynamic/biases/EchoNest.cpp 2d0038a 
>   src/scriptengine/AmarokCollectionScript.cpp da87d33 
>   src/services/lastfm/LastFmService.cpp 3b291fe 
>   src/services/lastfm/LastFmServiceSettings.cpp 6517fea 
>   src/services/lastfm/biases/LastFmBias.cpp 6f3286c 
>   src/services/lastfm/biases/WeeklyTopBias.cpp 98f9257 
> 
> Diff: http://git.reviewboard.kde.org/r/100008/diff
> 
> 
> Testing
> -------
> 
> This still fails to compile because of one error in libLastFM. Who is up for fixing the lib? :)
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100930/698551c3/attachment.htm