Review Request: Fix Bug 241641

[Conrad Hübler]

> On 2010-09-29 03:01:32, Leo Franchi wrote:
> > src/context/engines/current/CurrentEngine.cpp, line 228
> > <http://git.reviewboard.kde.org/r/100005/diff/1/?file=450#file450line228>
> >
> >     While this fixes the startup case, it's redundant in other cases, since m_currentTrack is set to the new playing track in engineTrackChanged.
> >     
> >     Does is still work if you set m_currentTrack in ::init() (you can override it, it's a virtual function in Plasma::DataEngine)

With the updated patch it should work without the redundance.


- Conrad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100005/#review35
-----------------------------------------------------------


On 2010-09-29 11:27:26, Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100005/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 11:27:26)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> This Patch fixes Bug 241641 which causes the current engine to be not up-to-date after startup when a should continue playing. Now the current track and the albums applet show the right information just after startup.
> 
> 
> This addresses bug 241641.
>     https://bugs.kde.org/show_bug.cgi?id=241641
> 
> 
> Diffs
> -----
> 
>   src/App.cpp 4d0625b 
>   src/context/engines/current/CurrentEngine.h 1214e50 
>   src/context/engines/current/CurrentEngine.cpp bb8e869 
> 
> Diff: http://git.reviewboard.kde.org/r/100005/diff
> 
> 
> Testing
> -------
> 
> Tested in the App and worked well.
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100929/a3869d5e/attachment.htm