Review Request: Use QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS for performance.

[Alex Merry]

On Wednesday 29 September 2010 09:36:12 Mark Kretschmann wrote:
>     I had to clean up lots of incorrect string concatenations. Please check
> for correctness.

So, reviewboard won't let me log on (I've filed a bug with the sysadmins), but 
I noticed at least one issue:

src/aboutdialog/OcsPersonItem.cpp

Your new code isn't equivalent to the old code in the case that both city and 
country is populated.  And I'm not convinced either version does the right 
thing when city is populated but not country (you end up with a trailing 
comma).

Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100929/f960bbb2/attachment.sig