Review Request: Current Track Applet showed wrong tracks

Leo Franchi lfranchi at kde.org
Wed Sep 29 04:06:48 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100006/#review34
-----------------------------------------------------------

Ship it!


Looks good to me! Nice fix.

Do you want to commit (do you have push rights?) or would you like me to commit for you?

- Leo


On 2010-09-28 13:56:35, Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100006/
> -----------------------------------------------------------
> 
> (Updated 2010-09-28 13:56:35)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> The Current Track Applet showed unplayed tracks (Meta::valLastPlayed = "2147483647"). The patch solves that problems by exclude that tracks.
> 
> 
> Diffs
> -----
> 
>   src/context/engines/current/CurrentEngine.cpp bb8e869 
> 
> Diff: http://git.reviewboard.kde.org/r/100006/diff
> 
> 
> Testing
> -------
> 
> Tested and worked on my system so far.
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100929/fe57d0ff/attachment.htm 


More information about the Amarok-devel mailing list