Review Request: Get FileType of SQLTracks from Database instead of File Extension

[Stefan Derkits]

> On 2010-09-28 05:06:58, Dan Meltzer wrote:
> > For the most part I like this idea.  If we are determining the information already, then we should use it, rather than solving it again.  That being said, I think that even as deep as taglib, the extension is used when scanning the file for metadata, so this isn't really going to solve the problem that you wanted to solve.

Thanks you Dan for your Comments, will make a new Version of the Patch today to tackle the Issues you described.

Also I know that TagLib unfortunatley just uses the Extension, at least in the CollectionScanner. There seems to be a FiletypeResolver in the Amarok Code that uses MimeTypes, but that uses the KMimeType Header and therefore can't be used in the CollectionScanner ... will see if there is some Alternative


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100004/#review28
-----------------------------------------------------------


On 2010-09-27 22:59:50, Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100004/
> -----------------------------------------------------------
> 
> (Updated 2010-09-27 22:59:50)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> -) Added a new Class Variable to SqlTrack to hold the FileType of a Track
> -) Retrieve FileType from Database and save it in the Class Variable
> -) Return a QString Representation of the Amarok::FileType when calling the Method SqlTrack::type()
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 
> 
> Diff: http://git.reviewboard.kde.org/r/100004/diff
> 
> 
> Testing
> -------
> 
> Hard to test, but the TagDialog displays the correct Filetypes
> Wanted to test it with a Testcase where FileType in Database is different then the FileExtension but realized that only certain FileExtensions are read by the CollectionScanner/TagLib :)
> So actually atm, the Code doesn't make much difference, but in my opinion this is a cleaner (and more future proof) Solution to display the Filetype then just displaying the Extension of the File
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100928/a1b3a3f2/attachment.htm