Review Request: Add ability to hide/show menubar

[Valentyn Pavliuchenko]

> On 2010-09-27 23:13:36, Mark Kretschmann wrote:
> > We actually removed this *on purpose* because of usability issues. Users would regularly complain over a missing menu. Ergo, sorry, but I don't think we'll bring this back.
> > 
> > Better solution: We'd think about replacing the traditional menu entirely, maybe like Chromium does.

Can you please explain the problem?
1. So it was enabled on some version?
2. In this patch it is also on a popup menu near the layout options.
3. And menu is still shown by default.
4. If some user hides the menu, then he will a) remember the shortcut (that is standard and is the same as other KDE apps) and b) will be able to find this option again in the layout popup menu.
5. We can show a message like "You're going to hide main menu bar. To show it back please use <shortcut> shortcut or use appropriate popup menu command" with Ok/Cancel answers. I think it will be safe for users.


- Valentyn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100002/#review27
-----------------------------------------------------------


On 2010-09-25 19:23:18, Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100002/
> -----------------------------------------------------------
> 
> (Updated 2010-09-25 19:23:18)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> Add Show Menubar to both main and popup menus to allow hiding/showing menu bar.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=210020.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=210020
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h e6ae0b3 
>   src/MainWindow.cpp 0eb6b28 
> 
> Diff: http://git.reviewboard.kde.org/r/100002/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Popup menu
>   http://git.reviewboard.kde.org/r/100002/s/3/
> 
> 
> Thanks,
> 
> Valentyn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100928/64e31ba4/attachment.htm