Review Request: MusicBrainz and MusicDNS services support implementation

[Sergey Ivanov]

> On 2010-09-22 02:22:07, Leo Franchi wrote:
> > src/CMakeLists.txt, line 791
> > <http://git.reviewboard.kde.org/r/100000/diff/1/?file=6#file6line791>
> >
> >     I'm not sure about the hard dependency of Xine. We don't depend on any particular audio backend since we use Phonon---what is the feasibility of using Phonon's AudioDataOutput for extracting the audio data, do you know? Some Amarok devs have been looking in to using it for audio fingerprinting, but it wasn't completely bug-free last I checked.
> 
> Sergey Ivanov wrote:
>     I didn't know that Phonon has such class, thank you.
> 
> Sergey Ivanov wrote:
>     Hmm, i can not find any way to make it just "dump" decoded date, everything this class can supply - dumps currently played portions of a track. And i didn't find a way to control playback to make It faster in case of decoding.
>     Guess I have to find another way.
> 
> Leo Franchi wrote:
>     Yeah i'm not so sure how well this will work. I don't mind the Xine dependency as long as (a) it's very clear it depends on Xine (b) There are CMakeLists checks for xine that enable it only if Xine is found, and disable it if Xine is not found. I don't know wh at the rest of the team thinks.
> 
> Mark Kretschmann wrote:
>     I'm not keen on the xine dependency. First of all xine is hardly maintained (they have like one developer left or so), which poses problems with bit-rot and possibly security issues. Then, it _is_ an extra dependency, with a whole slew of implicit dependencies that xine pulls in. Next issue, is xine cross-platform? Last I checked it did not run on Windows, and that automatically rules it out.
>     
>     So I realize that Phonon is unfortunately (not yet?) up to the task. We should talk to the Phonon devs about a possible extension here.
>     
>     As an alternative, how about using FFmpeg? We already depend on it for Teo's Transcoding patch. It's cross-platform. It's well maintained, and widely available on all distros. Sounds like a good match to me!
>

Already began to rewrite it to using separate libraries (libmad, flac, libogg etc..), so there is no more hard xine dependence. Btw found out that in last (mb both posted) diffs, checks for libofa availability was missed from  CMake script.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100000/#review6
-----------------------------------------------------------


On 2010-09-22 09:23:42, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100000/
> -----------------------------------------------------------
> 
> (Updated 2010-09-22 09:23:42)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> MusicBrainz and MusicDNS services support implementation.
> There are three independent parts:
> 1. MusicBrainzFinder class - used to make requests to MusicBrainz server and process replies. All relies process in separate threads by MusicBrainzXmlParser class. For a search uses guessed from a file name track information.  No external dependences required.
> 2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, but i communicate with musicdns server and receives track's PUID as a reply. Replies ether process in separate threads by MusicDNSXmlParser class. Fingerprints generated by libofa (the only external dependence in entire patch). For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'm not sure is It a good choice, but amarok based on phonon media-engine, that uses xine. So we don't deed to pull any other dependences). Received PUIDs sends to MusicBrainzFinder class, for a search routine.
> 3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrackListModel) and display (MusicBrainzTagsModelDelegate) purposes.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 191b02e 
>   cmake/modules/FindLibOFA.cmake PRE-CREATION 
>   config-amarok.h.cmake 981b7b7 
>   src/CMakeLists.txt 42614ff 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.h 6e15303 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 8205d45 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h e35b57f 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 9be62d9 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 8bdbf75 
>   src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp b5cb083 
>   src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 
>   src/core-impl/meta/file/File.h 6d4d395 
>   src/core-impl/meta/file/File.cpp 30cd2ff 
>   src/core-impl/meta/file/TagLibUtils.cpp 15b64a4 
>   src/core-impl/meta/proxy/MetaProxy.h 2ef3805 
>   src/core-impl/meta/proxy/MetaProxy.cpp 341e076 
>   src/core/capabilities/EditCapability.h 79344bd 
>   src/dialogs/MusicBrainzTagger.h PRE-CREATION 
>   src/dialogs/MusicBrainzTagger.cpp PRE-CREATION 
>   src/dialogs/MusicBrainzTagger.ui PRE-CREATION 
>   src/dialogs/TagDialog.h 50cd801 
>   src/dialogs/TagDialog.cpp 68fc5e3 
>   src/dialogs/TagDialogBase.ui 9974d0b 
>   src/musicbrainz/MusicBrainzFinder.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModelDelegate.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModelDelegate.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSFinder.h PRE-CREATION 
>   src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION 
>   src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION 
>   tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 55d1914 
> 
> Diff: http://git.reviewboard.kde.org/r/100000/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100924/92696fb5/attachment-0001.htm