Review Request: Patch for TagDialog - show Folder when editing multiple Files in the same Directory

[Mark Kretschmann]

Pushed to mainline.

One request: Next time, could you please generate the patch with "git
format-patch"? This way you can type the commit message yourself, and we
don't have to do copypasta.

http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html



On Wed, Sep 22, 2010 at 12:21 PM, Stefan Derkits <stefan at derkits.at> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/2/
>
> On September 20th, 2010, 11:27 a.m., *Bart Cerneels* wrote:
>
> Looks OK
>
>  Can someone submit this Patch to the GIT Repo?
>
>
> - Stefan
>
> On September 20th, 2010, 9:56 a.m., Stefan Derkits wrote:
>   Review request for amarok.
> By Stefan Derkits.
>
> *Updated 2010-09-20 09:56:58*
> Description
>
> Already submitted this Patch some Days ago via Mail, but I think it is easier to Review it here:
>
> Amarok has the possibility to edit the Tags of Multiple Files e.g. an
> Album and shows only the Tags that are exactly the same in all the Files.
>
> The only drawback of this for me was that I didn't see the Location
> (sometimes the Foldername, which is often the same for all Files in an
> Album, contains some Information I wanted to enter into the Tags) of the
> Files and had to check "per Track", remember the Information the
> Foldername revealed to me, uncheck "per Track" and enter the Information.
>
> My Patch changes this in a Way, that if all Files are local and in the
> same Directory it still displays the Location Label, Location LineEdit &
> OpenButton in the TagDialog and sets the Text of the LineEdit to the
> Folder where all the Files are.
>
> This way it is possible to see the Folder Name, even when you are
> editing multiple Files.
>
>   Testing
>
> Tested it in the App, the Folder shows up correctly when it should show up and doesn't show up when it shouldn't
>
>   Diffs
>
>    - src/dialogs/TagDialog.cpp (68fc5e3)
>
> View Diff <http://git.reviewboard.kde.org/r/2/diff/>
>
> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>


-- 
Mark Kretschmann
Amarok Developer
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://www.fsfe.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100922/27f411ab/attachment-0001.htm