Review Request: Patch for TagDialog - show Folder when editing multiple Files in the same Directory

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/2/#review3
-----------------------------------------------------------

Ship it!


Looks OK

- Bart


On 2010-09-20 09:56:58, Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/2/
> -----------------------------------------------------------
> 
> (Updated 2010-09-20 09:56:58)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> Already submitted this Patch some Days ago via Mail, but I think it is easier to Review it here:
> 
> Amarok has the possibility to edit the Tags of Multiple Files e.g. an
> Album and shows only the Tags that are exactly the same in all the Files.
> 
> The only drawback of this for me was that I didn't see the Location
> (sometimes the Foldername, which is often the same for all Files in an
> Album, contains some Information I wanted to enter into the Tags) of the
> Files and had to check "per Track", remember the Information the
> Foldername revealed to me, uncheck "per Track" and enter the Information.
> 
> My Patch changes this in a Way, that if all Files are local and in the
> same Directory it still displays the Location Label, Location LineEdit &
> OpenButton in the TagDialog and sets the Text of the LineEdit to the
> Folder where all the Files are.
> 
> This way it is possible to see the Folder Name, even when you are
> editing multiple Files.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/TagDialog.cpp 68fc5e3 
> 
> Diff: http://git.reviewboard.kde.org/r/2/diff
> 
> 
> Testing
> -------
> 
> Tested it in the App, the Folder shows up correctly when it should show up and doesn't show up when it shouldn't
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100920/b64e9636/attachment.htm