Review Request: New context menu applet to display guitar and bass-tablature

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100117/#review229
-----------------------------------------------------------


Thanks for the applet! I'm testing it now... Inline comments below. One note: in the screenshot,the reload icon is at the top left. It would be better to put that in the top-right, so it's consistent with the other applets.


src/context/applets/tabs/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100117/#comment175>

    Don't think you need this :)



src/context/applets/tabs/TabsApplet.h
<http://git.reviewboard.kde.org/r/100117/#comment176>

    remnant of a copy-paste I think :)



src/context/applets/tabs/TabsApplet.cpp
<http://git.reviewboard.kde.org/r/100117/#comment177>

    Best to put the Q_DECLARE_METATYPE in the header file (outside namespace declarations, inside the include guard) so it can be shared if needed.



src/context/applets/tabs/TabsApplet.cpp
<http://git.reviewboard.kde.org/r/100117/#comment178>

    You could use QString::number() here



src/context/applets/tabs/TabsView.cpp
<http://git.reviewboard.kde.org/r/100117/#comment179>

    Not sure what translating "source:" is supposed to mean. you could make it clearer to the translators by doing something like i18np( "the source of the guitar tabs", "source:" ) (off the top of my head)



src/context/applets/tabs/TabsView.cpp
<http://git.reviewboard.kde.org/r/100117/#comment180>

    we can probably skip translating a ) here :)
    
    also not sure about hardcoding colors in the html--have you tried with non-oxygen color schemes? you can use the utility functions in Applet (like hightlightColor) if you want a desaturated version of the current palette highlight color. I think it would be best to operate on a system color so it fits when the user changes color schemes.


- Leo


On 2010-10-31 14:28:25, Rainer Sigle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100117/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 14:28:25)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds a new applet to the Amarok context menu: "Tabs". It's designed for guitar and bass-players, as it downloads and displays tablature information for the current song. Directly playing along a song has therefore never been easier.
> 
> The tab data is currently fetched from two sites: www.ultimateguitar.com and www.fretplay.com. As these provide no direct API, the tab data is extracted using some simple HTML parsing. Multiple results, e.g. versions of the tab, are stored and can be choosen from a list. A settings dialog allows to define the type of tabs to be fetched. In this patch we've guitar and bass, but it could be extended to e.g. drums or piano in the future. Furthermore I've added a reload button which allows to easily refine the criteria for the tab-search. This can be used e.g. when no tab-results were found because the song name contains fragments like (live), remix, etc.
> 
> I'll send some new png-images to amarok devel mailinglist because I was not able to correctly include these binary files into the patch. Please be aware that I don't know if there are any copyright restrictions on these bitmaps! Maybe they can be replaced with some KDE/Plasma specific images. Unfortunately I didn't find anything appropriate.
> 
> Thanks for any feedback on this...
> 
> By the way: Also big Thanks! to all Amarok devs and supporters for their great work. I love this application.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/CMakeLists.txt 98bdd2b 
>   src/context/applets/tabs/CMakeLists.txt PRE-CREATION 
>   src/context/applets/tabs/ReloadEditDialog.ui PRE-CREATION 
>   src/context/applets/tabs/TabsApplet.h PRE-CREATION 
>   src/context/applets/tabs/TabsApplet.cpp PRE-CREATION 
>   src/context/applets/tabs/TabsItem.h PRE-CREATION 
>   src/context/applets/tabs/TabsItem.cpp PRE-CREATION 
>   src/context/applets/tabs/TabsSettings.ui PRE-CREATION 
>   src/context/applets/tabs/TabsView.h PRE-CREATION 
>   src/context/applets/tabs/TabsView.cpp PRE-CREATION 
>   src/context/applets/tabs/amarok-context-applet-tabs.desktop PRE-CREATION 
>   src/context/applets/tabs/amarok-tabs-bass.png PRE-CREATION 
>   src/context/applets/tabs/amarok-tabs-drum.png PRE-CREATION 
>   src/context/applets/tabs/amarok-tabs-guitar.png PRE-CREATION 
>   src/context/applets/tabs/amarok-tabs-piano.png PRE-CREATION 
>   src/context/engines/CMakeLists.txt c1f029e 
>   src/context/engines/tabs/CMakeLists.txt PRE-CREATION 
>   src/context/engines/tabs/TabsEngine.h PRE-CREATION 
>   src/context/engines/tabs/TabsEngine.cpp PRE-CREATION 
>   src/context/engines/tabs/TabsInfo.h PRE-CREATION 
>   src/context/engines/tabs/amarok-data-engine-tabs.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100117/diff
> 
> 
> Testing
> -------
> 
> used and tested during the last months, works fine for me
> 
> 
> Screenshots
> -----------
> 
> Tabs Applet
>   http://git.reviewboard.kde.org/r/100117/s/9/
> 
> 
> Thanks,
> 
> Rainer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101031/09e2bf6c/attachment-0001.htm