Review Request: Remove MainWindow dock layout resize hacks

Rick W. Chen stuffcorpse at archlinux.us
Sun Oct 31 04:20:26 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100107/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

This patch removes the dock resize hacks introduced in
8cb577dc891e13668098292f821f3a8131ced4b4, which was from the merge request
http://gitorious.org/amarok/amarok/merge_requests/154 .

There were dock resizing issues at the time, where the sizes and ratios of
different docks were not restored properly when maximizing and restarting
amarok. Now, at least with the new kde/qt dependencies I'm not experiencing
any problem of the sort.


Diffs
-----

  src/MainWindow.cpp 9102558 
  src/MainWindow.h 4593d47 

Diff: http://git.reviewboard.kde.org/r/100107/diff


Testing
-------

Tested with different dock arrangements:
- maximize and unmaximize window
- restart amarok
- hide and unhide window

The sizes and ratios of the docks remain the same.


Thanks,

Rick W.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101031/aba73968/attachment.htm 


More information about the Amarok-devel mailing list