Review Request: Show hidden dock widgets when activated by a bookmark

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100030/#review218
-----------------------------------------------------------

Ship it!


While I agree it's not the best solution, it solves a real problem and isn't really very much code. It's clear what it does and how it does it. So, go ahead and push!

- Leo


On 2010-10-08 12:51:02, Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100030/
> -----------------------------------------------------------
> 
> (Updated 2010-10-08 12:51:02)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Since I have tabbed my Navigation and Context views I have to manually select the tabs every time I open a bookmark.
> In my opinion this should be done automatically.
> Unfortunately I couldn't come up with a very clean solution. But please have a look at the code yourself and share your opinion.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b86470e 
>   src/MainWindow.cpp 54c6751 
>   src/amarokurls/ContextUrlRunner.cpp 7416fbc 
>   src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b 
>   src/playlist/PlaylistViewUrlRunner.cpp 749233e 
> 
> Diff: http://git.reviewboard.kde.org/r/100030/diff
> 
> 
> Testing
> -------
> 
> I'm running amarok with this patch for many weeks now without any problems.
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101030/dd085528/attachment.htm