Review Request: Support of MPC and MP4 formats for AFTTagger.

[Sergey Ivanov]

> On 2010-10-27 00:37:26, Rick W. Chen wrote:
> > utilities/afttagger/AFTTagger.cpp, lines 692-693
> > <http://git.reviewboard.kde.org/r/100080/diff/5/?file=2535#file2535line692>
> >
> >     needs to be in the form "----:org:id"
> >     
> >     so perhaps something like "----:ourId:Amarok AFT ID"?

Initially It was "----:com.apple.iTunes:" + ourId, but then I switched from http://wiki.musicbrainz.org/PicardTagMapping scheme to http://wiki.musicbrainz.org/MusicBrainzTag. I guess I need to roll It back.

And the question: Do we really need to store version of AFT?


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100080/#review204
-----------------------------------------------------------


On 2010-10-25 21:32:11, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100080/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 21:32:11)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add support of MPC and MP4 formats for AFTTagger utility.
> 
> 
> Diffs
> -----
> 
>   utilities/collectionscanner/AFTUtility.cpp fde3bfa 
>   utilities/afttagger/AFTTagger.h 8921875 
>   utilities/afttagger/AFTTagger.cpp 2aa9aef 
> 
> Diff: http://git.reviewboard.kde.org/r/100080/diff
> 
> 
> Testing
> -------
> 
> Tried on couple of MPC files, UIDs write correct. AFTTagger not tested at all, didn't find a way to make it well.
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101027/5baa1d0f/attachment.htm