Review Request: Support of MPC and MP4 formats for AFTTagger.

[Rick W. Chen]

> On 2010-10-26 14:26:06, Sergey Ivanov wrote:
> > And so. Verdict for this patch is ... . :)

MP4 AFT tagger was failing. TagLib requires mp4 freeform tag key to be in this form "----:org:id". See diff comment.

I test this by running afttagger on a directory of .m4a's and then run amarokcollectionscanner and see if it outputs mbid or aft in the sqltrackuids.


- Rick W.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100080/#review202
-----------------------------------------------------------


On 2010-10-25 21:32:11, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100080/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 21:32:11)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add support of MPC and MP4 formats for AFTTagger utility.
> 
> 
> Diffs
> -----
> 
>   utilities/collectionscanner/AFTUtility.cpp fde3bfa 
>   utilities/afttagger/AFTTagger.h 8921875 
>   utilities/afttagger/AFTTagger.cpp 2aa9aef 
> 
> Diff: http://git.reviewboard.kde.org/r/100080/diff
> 
> 
> Testing
> -------
> 
> Tried on couple of MPC files, UIDs write correct. AFTTagger not tested at all, didn't find a way to make it well.
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101027/996f0f47/attachment.htm