Review Request: "Album Artist" field support.

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100084/
-----------------------------------------------------------

(Updated 2010-10-25 22:27:27.193696)


Review request for Amarok.


Changes
-------

Shrunken version of patch. Only setAlbumArtist left.


Summary (updated)
-------

Some try to handle "Album Artist" data (ability to store/load It in/from file). Support of updating/setting "Album Artist" for albums in SQLCollection.


Diffs (updated)
-----

  src/core-impl/capabilities/timecode/TimecodeEditCapability.h 286cb3f 
  src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 9a69079 
  src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h f9ae81f 
  src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 55e05e5 
  src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp a81c91d 
  src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp 0e3578a 
  src/core-impl/collections/sqlcollection/SqlMeta.h 5c416d3 
  src/core-impl/collections/sqlcollection/SqlMeta.cpp 7a210d3 
  src/core-impl/meta/file/File.h 9ab364b 
  src/core-impl/meta/file/File.cpp 51475fc 
  src/core-impl/meta/proxy/MetaProxy.h 3bae966 
  src/core-impl/meta/proxy/MetaProxy.cpp 450cd6e 
  src/core/capabilities/EditCapability.h ba91ef9 
  src/dialogs/TagDialog.cpp f0e671a 
  tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 97e0281 

Diff: http://git.reviewboard.kde.org/r/100084/diff


Testing
-------

Tested as I could. Works fine.
Found out that I have ~5 different "Best Of" albums of different artists, but not the only 1 as I thought before. :)


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101025/4e2f5b63/attachment.htm