Review Request: UPnP Collection

[Ian Monroe]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100065/#review199
-----------------------------------------------------------



src/core-impl/collections/upnpcollection/UpnpCache.h
<http://git.reviewboard.kde.org/r/100065/#comment161>

    Is the order of these types really important? This code would be faster with a QHash instead.



src/core-impl/collections/upnpcollection/UpnpCollectionBase.cpp
<http://git.reviewboard.kde.org/r/100065/#comment162>

    should be QLatin1Literal instead



src/core-impl/collections/upnpcollection/UpnpCollectionBase.cpp
<http://git.reviewboard.kde.org/r/100065/#comment163>

    QLatin1Literal



src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp
<http://git.reviewboard.kde.org/r/100065/#comment164>

    QLatin1Litera



src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp
<http://git.reviewboard.kde.org/r/100065/#comment165>

    QLatin1Literal
    
    (etc, etc, basically whenever you have a literal string being pased to a method that expects a QString, you should use i18n or QLatin1Literal. In this way, QString doesn't have to guess the text encoding at runtime. Occasionally QLatin1Literal doesn't work, then use QLatin1String.)


- Ian


On 2010-10-17 11:30:11, Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100065/
> -----------------------------------------------------------
> 
> (Updated 2010-10-17 11:30:11)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Adds UPnP collection support.
> 
> 1) Depends on the Cagibi SSDP daemon for discovery and the UPnP KIO slave (http://gitorious.org/kio-upnp-ms) for browse
> 2) Each upnp device is represented as a collection.
> 3) Tries to use search based collection to reduce memory usage and push complexity to the server. Falls back to MemoryCollection and simple browse when search is not supported
> 4) BrowseCollection performs a full scan using KIO::listDir
> 5) SearchCollection uses the slave and queues up jobs as required. The slave API is documented in the slave (controlpointthread.h)
> 
> Other than code feedback, I am not sure about certain build parameters
> 1) How do I check if the upnp kio slave is installed? Right now I'm checking for hupnp, but that probably isn't the right way
> 
> What is left:
> * In certain cases, the CPU usage goes very high when running a full scan using BrowseCollection
> * Needs some profiling
> * Fix warnings
> 
> 
> This addresses bug 145683.
>     https://bugs.kde.org/show_bug.cgi?id=145683
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt baacef5 
>   cmake/modules/FindHUpnp.cmake PRE-CREATION 
>   src/core-impl/collections/CMakeLists.txt 1e29df7 
>   src/core-impl/collections/upnp/CMakeLists.txt 441cd04 
>   src/core-impl/collections/upnp/amarok_collection-upnpcollection.desktop 061b661 
>   src/core-impl/collections/upnpcollection/CMakeLists.txt PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpBrowseCollection.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCache.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCache.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCollectionBase.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCollectionBase.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpMemoryQueryMaker.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpMeta.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpMeta.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQuery.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQuery.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpQueryMakerInternal.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpSearchCollection.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/amarok_collection-upnpcollection.desktop PRE-CREATION 
>   src/core-impl/collections/upnpcollection/dbuscodec.h PRE-CREATION 
>   src/core-impl/collections/upnpcollection/dbuscodec.cpp PRE-CREATION 
>   src/core-impl/collections/upnpcollection/deviceinfo.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100065/diff
> 
> 
> Testing
> -------
> 
> Tested with:
> 
> MediaTomb - browse based
> Fuppes - search based
> miniDLNA - search based (high quality)
> 
> There are issues with Windows Media Player's inbuilt upnp server. Some don't get accessed, and some don't stream their music at all. This may or may not be an upstream bug, or perhaps WMP's upnp is not standards compliant. Either way it requires investigation.
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101025/5a2d3914/attachment-0001.htm