Review Request: Small EngineController refactoring

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100097/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

It turned out that calling EngineController::play did not call Track::finishedPlaying.
This was done by the PlaylistActions.
In all other cases the EngineController called finishedPlaying by itself.

So I moved the function from PlaylistActions to the controller.
As it turned out the EngineController even leaked BoundedPlaybackCapability objects in stop().

I hope this fixes 254631, but I think that the chances are not good.


This addresses bug 254631.
    https://bugs.kde.org/show_bug.cgi?id=254631


Diffs
-----

  src/EngineController.cpp 5e07700 
  src/playlist/PlaylistActions.cpp bc6ef5b 

Diff: http://git.reviewboard.kde.org/r/100097/diff


Testing
-------

Playing around with stop, next and so on while looking for the finishedPlaying debug output.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101022/6138a6a5/attachment.htm