Review Request: Add MusicBrainz search result threshold, and manual run of MusicDNS search. Some cleaning of MB staff.

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100084/
-----------------------------------------------------------

(Updated 2010-10-21 23:51:07.806709)


Review request for Amarok.


Changes
-------

Clean out all useless code, left from 1st version of MB subsystem (with complete track list). Rewrite It to use simple QVariantMaps instead of MB specific classes (MusicBrainzTrack, MusicBrainzArtist, MusicBrainzRelease). Add ID namespace to Meta::Fields.


Summary (updated)
-------

Add search result threshold (60% similarity level).
Now, after first (automatic) search, "Start search" button runs MusicDNS (fingerprint based) search.
Clean out all useless code, left from 1st version of MB subsystem (with complete track list). Rewrite It to use simple QVariantMaps instead of MB specific classes (MusicBrainzTrack, MusicBrainzArtist, MusicBrainzRelease). Add ID namespace to Meta::Fields (It won't apply with http://git.reviewboard.kde.org/r/100080/ patch).


Diffs (updated)
-----

  src/CMakeLists.txt 45a9493 
  src/core-impl/collections/sqlcollection/SqlMeta.cpp 97969be 
  src/core-impl/meta/file/File.cpp b807cba 
  src/core-impl/meta/file/TagLibUtils.cpp ad1a07e 
  src/core/meta/support/MetaConstants.h 40cad34 
  src/dialogs/MusicBrainzTagger.h d053e88 
  src/dialogs/MusicBrainzTagger.cpp 6f18606 
  src/dialogs/TagDialog.cpp 4a0e94f 
  src/musicbrainz/MusicBrainzFinder.h 6fe3a47 
  src/musicbrainz/MusicBrainzFinder.cpp f65e25d 
  src/musicbrainz/MusicBrainzMetaClasses.h b9f7d0c 
  src/musicbrainz/MusicBrainzMetaClasses.cpp da83c16 
  src/musicbrainz/MusicBrainzTagsModel.h cc1552e 
  src/musicbrainz/MusicBrainzTagsModel.cpp f1dd54a 
  src/musicbrainz/MusicBrainzTrackListModel.cpp 442e662 
  src/musicbrainz/MusicBrainzXmlParser.h b0e9089 
  src/musicbrainz/MusicBrainzXmlParser.cpp b57baad 
  src/musicbrainz/MusicDNSFinder.h 474c998 
  src/musicbrainz/MusicDNSFinder.cpp c026a8e 
  src/musicbrainz/MusicDNSXmlParser.h a9b67e0 

Diff: http://git.reviewboard.kde.org/r/100084/diff


Testing (updated)
-------

Tested as I could. Works fine.


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101021/48398647/attachment.htm