Review Request: Fix problem with inline editing in playlist.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100039/#review168
-----------------------------------------------------------

Ship it!


Has this already been pushed to mainline? It says "Patch Reversed" here, but I can't find it in the git log. *confused*


- Mark


On 2010-10-20 15:38:41, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100039/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 15:38:41)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fixes three problems:
> 1. Alignment was not considered with rating widget when editing
> 2. Calculation of item height was incorrect leading to the problem that three line items would not show the third line when editing
> 3. QStyle pixel metrics were disregarded
> 
> 
> Diffs
> -----
> 
>   src/playlist/view/listview/InlineEditorWidget.h f14d6df 
>   src/playlist/view/listview/InlineEditorWidget.cpp a7e981b 
>   src/playlist/view/listview/PrettyItemDelegate.h a929ecb 
>   src/playlist/view/listview/PrettyItemDelegate.cpp 183f9cd 
>   src/playlist/view/listview/PrettyListView.cpp 538cbaa 
> 
> Diff: http://git.reviewboard.kde.org/r/100039/diff
> 
> 
> Testing
> -------
> 
> Editing with one, two and three line layouts.
> Using Oxygen and normal styles.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/100039/s/6/
> After (stars too small, text clipping)
>   http://git.reviewboard.kde.org/r/100039/s/7/
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101021/878fca7c/attachment.htm