Review Request: Fix test PlaylistModel

[Bart Cerneels]

> On 2010-10-20 09:39:52, Bart Cerneels wrote:
> > src/playlist/proxymodels/SortFilterProxy.h, line 81
> > <http://git.reviewboard.kde.org/r/100090/diff/1/?file=1195#file1195line81>
> >
> >     s/meaning/means
> >     It's not much but the sentence confused me when I first read it.
> 
> Ralf Engels wrote:
>     Apart from the wording any other complaints?
>     Wouldn't it be better for the UI to set a timer for setting the filter?

Well, the absolute best option would be to apply the filter even after typing the first character and interrupt and restart as soon as a new character is typed. This would give a dynamic UI with instant feedback. But as you mention, applying the filter could block the UI for seconds so it's not an option. In this case I think it's best to only apply on enter. Isn't that how it works currently?


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100090/#review141
-----------------------------------------------------------


On 2010-10-20 09:25:28, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100090/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 09:25:28)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Two tests for PlaylistModel were failing.
> In both cases it seems to be a regression.
> 
> 
> Diffs
> -----
> 
>   src/playlist/proxymodels/SortAlgorithms.cpp 9f8c563 
>   src/playlist/proxymodels/SortFilterProxy.h 2d4058f 
>   tests/playlist/TestPlaylistModels.cpp 8b7b90a 
> 
> Diff: http://git.reviewboard.kde.org/r/100090/diff
> 
> 
> Testing
> -------
> 
> Run the testcase.
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101020/6a80992e/attachment-0001.htm