Review Request: Fix test PlaylistModel
Bart Cerneels
bart.cerneels at kde.org
Wed Oct 20 11:39:50 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100090/#review141
-----------------------------------------------------------
Ship it!
src/playlist/proxymodels/SortFilterProxy.h
<http://git.reviewboard.kde.org/r/100090/#comment122>
s/meaning/means
It's not much but the sentence confused me when I first read it.
- Bart
On 2010-10-20 09:25:28, Ralf Engels wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100090/
> -----------------------------------------------------------
>
> (Updated 2010-10-20 09:25:28)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Two tests for PlaylistModel were failing.
> In both cases it seems to be a regression.
>
>
> Diffs
> -----
>
> src/playlist/proxymodels/SortAlgorithms.cpp 9f8c563
> src/playlist/proxymodels/SortFilterProxy.h 2d4058f
> tests/playlist/TestPlaylistModels.cpp 8b7b90a
>
> Diff: http://git.reviewboard.kde.org/r/100090/diff
>
>
> Testing
> -------
>
> Run the testcase.
>
>
> Thanks,
>
> Ralf
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101020/4ac2f4c2/attachment-0001.htm
More information about the Amarok-devel
mailing list