Review Request: Last.fm: submit composer under "artist" if available

[Sergey Ivanov]

> On 2010-10-19 19:40:28, Sergey Ivanov wrote:
> > src/services/lastfm/ScrobblerAdapter.cpp, line 82
> > <http://git.reviewboard.kde.org/r/100089/diff/1/?file=1193#file1193line82>
> >
> >     You'll submit composer as artist even if you have artist name. It's better to check artist name first.
> 
> Nicholas Wilson wrote:
>     No, that's precisely the point. Last.fm has artist pages for composers, but not for each combination of conductor, orchestra and soloist (tested—it can't work out any of my artists). If the track has a composer tag, that is certainly what the user wants to post. If the composer tag is empty, we don't know what jumble of information has been put in the artist tag, but we have to send it anyway. The only thing that would ever go in the composer tag though is the actual composer, which is what last.fm wants. So, we submit composer preferentially if we know we have that information to send.

Then It's Ok. Ship it.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100089/#review137
-----------------------------------------------------------


On 2010-10-19 19:16:22, Nicholas Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100089/
> -----------------------------------------------------------
> 
> (Updated 2010-10-19 19:16:22)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Submit composer information as "artist" if available when posting to last.fm.
> 
> 
> This addresses bug 254580.
>     https://bugs.kde.org/show_bug.cgi?id=254580
> 
> 
> Diffs
> -----
> 
>   src/services/lastfm/ScrobblerAdapter.cpp 47df3e3 
> 
> Diff: http://git.reviewboard.kde.org/r/100089/diff
> 
> 
> Testing
> -------
> 
> None; I need to re-install my old KDE4 dev enviroment (sorry!—will have tests run soon). Patch "visibly" correct
> 
> 
> Thanks,
> 
> Nicholas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/779fc546/attachment.htm