Review Request: Fix problem with inline editing in playlist.

[Rick W. Chen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100039/
-----------------------------------------------------------

(Updated 2010-10-19 13:06:32.035638)


Review request for Amarok.


Changes
-------

I'm experiencing some text clipping issues and the rating stars too small. Shown in screenshots.


Summary
-------

Fixes three problems:
1. Alignment was not considered with rating widget when editing
2. Calculation of item height was incorrect leading to the problem that three line items would not show the third line when editing
3. QStyle pixel metrics were disregarded


Diffs
-----

  src/playlist/view/listview/InlineEditorWidget.h f14d6df 
  src/playlist/view/listview/InlineEditorWidget.cpp a7e981b 
  src/playlist/view/listview/PrettyItemDelegate.h a929ecb 
  src/playlist/view/listview/PrettyItemDelegate.cpp 183f9cd 
  src/playlist/view/listview/PrettyListView.cpp ca3d580 

Diff: http://git.reviewboard.kde.org/r/100039/diff


Testing
-------

Editing with one, two and three line layouts.
Using Oxygen and normal styles.


Screenshots
-----------

Before
  http://git.reviewboard.kde.org/r/100039/s/6/
After (stars too small, text clipping)
  http://git.reviewboard.kde.org/r/100039/s/7/


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/bb471e8b/attachment.htm