Review Request: Use default tooltip for playlist tooltips.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100083/#review129
-----------------------------------------------------------

Ship it!


Works fine here, and saves /a lot of/ code. Good patch.

- Mark


On 2010-10-18 20:17:41, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100083/
> -----------------------------------------------------------
> 
> (Updated 2010-10-18 20:17:41)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Use the default Qt tooltips for playlist tooltips. 
> The playlist tooltip text was invisible on black backgounds.
> In addition the custom tooltip implementation did not follow the platform style, was complicate and unneeded.
> Just using a normal tooltip solves all problems.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c55bb83 
>   src/playlist/PlaylistModel.h f213d65 
>   src/playlist/PlaylistModel.cpp 4008cf9 
>   src/playlist/view/listview/PrettyListView.h e4893e3 
>   src/playlist/view/listview/PrettyListView.cpp ca3d580 
>   src/playlist/view/tooltips/AmarokToolTip.cpp 831f08d 
>   src/playlist/view/tooltips/KFormattedBalloonTipDelegate.cpp e8a1479 
>   src/playlist/view/tooltips/KToolTip.cpp d219cf9 
>   src/playlist/view/tooltips/KToolTipDelegate.cpp 2724031 
>   src/playlist/view/tooltips/KToolTipItem.cpp cbc09b3 
>   src/playlist/view/tooltips/ToolTipManager.cpp ffe91b5 
> 
> Diff: http://git.reviewboard.kde.org/r/100083/diff
> 
> 
> Testing
> -------
> 
> Testing on two different machines with different styles and colors.
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/8d6270f0/attachment.htm