Review Request: Fix problem with inline editing in playlist.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100039/
-----------------------------------------------------------

(Updated 2010-10-19 00:16:28.599392)


Review request for Amarok.


Changes
-------

Updated inline editing patch.
With setFrame(false) I was able to save considerably space.
Also I noticed some smallish problems when:
-Editing a one lined layout with cover image
-Italic font was not used in editor

I tested it again with Oxygen and all other styles that I have here.


Summary
-------

Fixes three problems:
1. Alignment was not considered with rating widget when editing
2. Calculation of item height was incorrect leading to the problem that three line items would not show the third line when editing
3. QStyle pixel metrics were disregarded


Diffs (updated)
-----

  src/playlist/view/listview/InlineEditorWidget.h f14d6df 
  src/playlist/view/listview/InlineEditorWidget.cpp a7e981b 
  src/playlist/view/listview/PrettyItemDelegate.h a929ecb 
  src/playlist/view/listview/PrettyItemDelegate.cpp 183f9cd 
  src/playlist/view/listview/PrettyListView.cpp ca3d580 

Diff: http://git.reviewboard.kde.org/r/100039/diff


Testing
-------

Editing with one, two and three line layouts.
Using Oxygen and normal styles.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101019/8158c355/attachment-0001.htm