Review Request: Prevent line break in context pane tool bar
Rick W. Chen
stuffcorpse at archlinux.us
Mon Oct 18 16:00:06 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100069/#review119
-----------------------------------------------------------
src/context/toolbar/AppletToolbarAppletItem.h
<http://git.reviewboard.kde.org/r/100069/#comment83>
Would a QGraphicsSimpleTextItem be more suitable here?
- Rick W.
On 2010-10-18 11:55:14, Ralf Engels wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100069/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 11:55:14)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Use a QGraphicsTextObject instead of Plasma::Label
> Plasma::Label is automatically linebreaking the text which leads to the problem that the tool bar in the context pane displays only "Current" instead of "Current Track".
>
>
> Diffs
> -----
>
> src/context/toolbar/AppletToolbarAppletItem.h 2cadbfd
> src/context/toolbar/AppletToolbarAppletItem.cpp a816337
>
> Diff: http://git.reviewboard.kde.org/r/100069/diff
>
>
> Testing
> -------
>
> Used different color schemes to check if the text becomes invisible in one of them.
>
>
> Thanks,
>
> Ralf
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101018/6c95a527/attachment.htm
More information about the Amarok-devel
mailing list