Review Request: Show hidden dock widgets when activated by a bookmark

[Daniel Faust]

> On 2010-10-09 16:56:38, Thomas Lübking wrote:
> > Yes it does ;-)
> > 
> > (be aware that i wrote that "just down" - the vars/classnames might slightly differ and there're likely typos =)
> > 
> > MainWindow::setDockAsCurrentTabWidget( char docktype )
> > {
> >    QDockWidget *dock(0);
> >    switch (docktype)
> >    {
> >    case 'p': dock = playlistDock; break;
> >    case 'c': dock = contextDock; break;
> >    case 'm': dock = mediaSourcesDock; break;
> >    default: return; // invalid request
> >    }
> >    if ( !tabifiedDockWidgets(dock).isEmpty() ) // is actually tabbed
> >       tabifyDockWidget(  docks.at(docks.count()-1), dock ); // tabify moves second on top of first, either 0 or c-1 should do...
> > }
> 
> Thomas Lübking wrote:
>     d'oooh - oc. it must be sth. like
>     
>     QList<QDockWidget*> docks = tabifiedDockWidgets(dock);
>     if (!docks.isEmpty())
>        ...
>     
>     (ie. forgot to define docks ;-)
> 
> Daniel Faust wrote:
>     Ok, now I got it.
>     But it still doesn't solve the problem properly. The second dock is not only moved above the fist one but also to the right of it.
>     So if I try to give the most left dock the focus it gets moved to the right of the reference dock. (very irritating)
> 
> Mark Kretschmann wrote:
>     Any progress with this one?
> 
> Thomas Lübking wrote:
>     I should rather not group mails by week ;-)
>     
>     Daniel is right and unfortunately there's no clean way to prevent this (you'd have to store and restore the tab order, but therefore you'd need to identify the tabbar as well as the position of the demanded dock)
>     
>     Since the QDockAreaLayout is (unfortunately.) private there's really no clean solution for this :-(

So the question is whether to merge the patch as it is, or not.
It isn't very clean, but I would merge it anyway because it is a very small and well-defined piece of code and it improves the usability.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100030/#review81
-----------------------------------------------------------


On 2010-10-08 12:51:02, Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100030/
> -----------------------------------------------------------
> 
> (Updated 2010-10-08 12:51:02)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Since I have tabbed my Navigation and Context views I have to manually select the tabs every time I open a bookmark.
> In my opinion this should be done automatically.
> Unfortunately I couldn't come up with a very clean solution. But please have a look at the code yourself and share your opinion.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b86470e 
>   src/MainWindow.cpp 54c6751 
>   src/amarokurls/ContextUrlRunner.cpp 7416fbc 
>   src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b 
>   src/playlist/PlaylistViewUrlRunner.cpp 749233e 
> 
> Diff: http://git.reviewboard.kde.org/r/100030/diff
> 
> 
> Testing
> -------
> 
> I'm running amarok with this patch for many weeks now without any problems.
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101018/9fff1814/attachment.htm