Review Request: Add ability to hide/show menubar

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100002/#review103
-----------------------------------------------------------

Ship it!


After the changes that Valentyn made (especially the warning dialog), I am now in favor of merging this. I'd say, let's give it a try.


Minor issues I noticed:

There are grammar mistakes in the dialog, and it should have "Please" as the first word, to appear friendlier.


- Mark


On 2010-10-09 21:39:52, Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100002/
> -----------------------------------------------------------
> 
> (Updated 2010-10-09 21:39:52)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add Show Menubar to both main and popup menus to allow hiding/showing menu bar.
> 
> 
> This addresses bug 210020.
>     https://bugs.kde.org/show_bug.cgi?id=210020
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h e6ae0b3 
>   src/MainWindow.cpp 0eb6b28 
> 
> Diff: http://git.reviewboard.kde.org/r/100002/diff
> 
> 
> Testing
> -------
> 
> Tested functionality: all ok.
> 
> 
> Screenshots
> -----------
> 
> Warning dialog
>   http://git.reviewboard.kde.org/r/100002/s/4/
> Context menu
>   http://git.reviewboard.kde.org/r/100002/s/5/
> 
> 
> Thanks,
> 
> Valentyn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101016/d87d2bfc/attachment.htm