Review Request: Fix Bug 243562 regarding fuzzy bias and a small layout issue

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100035/#review91
-----------------------------------------------------------

Ship it!


Patch looks good to me. And seems to work, as far as I can tell.

- Mark


On 2010-10-09 18:18:13, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100035/
> -----------------------------------------------------------
> 
> (Updated 2010-10-09 18:18:13)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Change order of setting filter and value (one resets the other)
> First set the values and then connect the signal
> For the layout set the layout policy.
> 
> 
> This addresses bug 243562.
>     https://bugs.kde.org/show_bug.cgi?id=243562
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/DynamicBiasWidgets.cpp ae1eb19 
>   src/widgets/MetaQueryWidget.h 4d544c7 
>   src/widgets/MetaQueryWidget.cpp 5f9171a 
> 
> Diff: http://git.reviewboard.kde.org/r/100035/diff
> 
> 
> Testing
> -------
> 
> Tested with fuzzy and global bias. Exspecially the scenario in the bug entry
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101015/75867d44/attachment.htm