Review Request: Fix problem with inline editing in playlist.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100039/#review90
-----------------------------------------------------------


Ralf, with my "Verbose" playlist layout, all the lines have become about 50% taller with your patch. So the playlist takes up much more vertical space.

Is this intended? I'm not sure it's a good idea to use so much vertical space.


- Mark


On 2010-10-09 18:27:00, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100039/
> -----------------------------------------------------------
> 
> (Updated 2010-10-09 18:27:00)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fixes three problems:
> 1. Alignment was not considered with rating widget when editing
> 2. Calculation of item height was incorrect leading to the problem that three line items would not show the third line when editing
> 3. QStyle pixel metrics were disregarded
> 
> 
> Diffs
> -----
> 
>   src/playlist/view/listview/InlineEditorWidget.h f14d6df 
>   src/playlist/view/listview/InlineEditorWidget.cpp a7e981b 
>   src/playlist/view/listview/PrettyItemDelegate.h a929ecb 
>   src/playlist/view/listview/PrettyItemDelegate.cpp 31d4379 
>   src/playlist/view/listview/PrettyListView.cpp ca3d580 
> 
> Diff: http://git.reviewboard.kde.org/r/100039/diff
> 
> 
> Testing
> -------
> 
> Editing with one, two and three line layouts.
> Using Oxygen and normal styles.
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101015/1164289f/attachment.htm