Review Request: Add ability to hide/show menubar

[Valentyn Pavliuchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100002/
-----------------------------------------------------------

(Updated 2010-10-09 21:34:14.871495)


Review request for Amarok.


Changes
-------

1. Moved menu item to Settings menu (the same as other KDE apps).
2. Added warning dialog (see the screenshot).
3. Updated behavior to match Dolphin/Konqueror: context menu item is shown only when menu is hidden.


Summary
-------

Add Show Menubar to both main and popup menus to allow hiding/showing menu bar.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=210020.
    https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=210020


Diffs (updated)
-----

  src/MainWindow.h e6ae0b3 
  src/MainWindow.cpp 0eb6b28 

Diff: http://git.reviewboard.kde.org/r/100002/diff


Testing
-------


Screenshots
-----------

Popup menu
  http://git.reviewboard.kde.org/r/100002/s/3/
Warning dialog
  http://git.reviewboard.kde.org/r/100002/s/4/


Thanks,

Valentyn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101009/5e04e8ca/attachment.htm